Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2811: update frontend-maven-plugin #273

Merged
merged 1 commit into from
Apr 7, 2022
Merged

CIF-2811: update frontend-maven-plugin #273

merged 1 commit into from
Apr 7, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Apr 7, 2022

Description

With this change we move parts of frontend-maven-plugin configuration to the parent module to reduce duplication. We also update the version to the latest release.

Related Issue

CIF-2811
eirslett/frontend-maven-plugin#970

Motivation and Context

Support builds on Apple Silicon with node versions older than 16

How Has This Been Tested?

Build locally, CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the releng Release Engineering label Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #273 (e71b655) into main (fc04b1b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #273   +/-   ##
=========================================
  Coverage     86.20%   86.20%           
  Complexity       19       19           
=========================================
  Files             1        1           
  Lines            29       29           
  Branches          4        4           
=========================================
  Hits             25       25           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 86.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04b1b...e71b655. Read the comment docs.

@buuhuu buuhuu merged commit bb5cc16 into main Apr 7, 2022
@buuhuu buuhuu deleted the issue/CIF-2811 branch April 7, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants